Home - Waterfall Grid T-Grid Console Builders Recent Builds Buildslaves Changesources - JSON API - About

Builder Linux64 - Nginx (Mainline) Build #15

Results:

Build successful

SourceStamp:

Repositoryhttps://github.com/SpiderLabs/ModSecurity
Branchnginx_refactoring
Revisionb058a9f8ba90849262302a9e987d021bad02de84
Got Revisionb058a9f8ba90849262302a9e987d021bad02de84
Changes11 changes

BuildSlave:

Linux64

Reason:

The AnyBranchScheduler scheduler named 'all-any' triggered this build

Steps and Logfiles:

  1. fetch update ( 25 secs )
    1. stdio
  2. autogen (ModSec) autogen ( 1 mins, 49 secs )
    1. stdio
  3. configure (ModSec) configure ( 4 mins, 6 secs )
    1. stdio
  4. make (ModSec) Compilation warnings ( 8 mins, 38 secs )
    1. stdio
    2. warnings (2)
  5. download downloading to nginx.tar.gz ( 35 secs )
    1. - no logs -
  6. extract nginx tarball (nginx) extract - mainline ( 1 secs )
    1. stdio
  7. download_1 downloading to echo.tar.gz ( 4 secs )
    1. - no logs -
  8. extract echo tarball (nginx/echo) extract ( 0 secs )
    1. stdio
  9. configure nginx (nginx) configure ( 3 mins, 14 secs )
    1. stdio
  10. make nginx (nginx) Compilation ( 7 mins, 6 secs )
    1. stdio
  11. download_2 downloading to modsec.conf ( 2 secs )
    1. - no logs -
  12. download_3 downloading to nginx-tests.tar.gz ( 25 secs )
    1. - no logs -
  13. extract nginx regressin tarball (nginx/tests) extract ( 1 secs )
    1. stdio
  14. get_builddir property 'builddir' set ( 0 secs )
    1. stdio
    2. property changes
  15. nginx tests nginx tests failed ( 1 hrs, 1 mins, 54 secs )
    1. stdio
  16. download_4 downloading to check-coding_style.sh ( 1 secs )
    1. - no logs -
  17. coding style standalone Coding style (ModSec Standalone) warnings ( 48 secs )
    1. stdio
    2. warnings (3275)
  18. coding style nginx Coding style (ModSec nginx) ( 4 secs )
    1. stdio
  19. download_5 downloading to cppcheck.sh ( 2 secs )
    1. - no logs -
  20. static analisys standalone Static analisys (ModSec Standalone) warnings ( 11 mins, 24 secs )
    1. stdio
    2. warnings (674)
  21. coding style nginx_1 Static analisys (ModSec nginx) warnings ( 6 secs )
    1. stdio
    2. warnings (26)
  22. download_6 downloading to clean.sh ( 1 secs )
    1. - no logs -
  23. clean clean semaphores ( 0 secs )
    1. stdio
  24. unit test make test ( 13 mins, 38 secs )
    1. stdio
  25. unit test_1 unit tests ( 11 mins, 54 secs )
    1. stdio
  26. clean_1 clean semaphores ( 1 secs )
    1. stdio
  27. regression test regression [8086] ( 11 mins, 21 secs )
    1. stdio

Build Properties:

NameValueSource
branch nginx_refactoring Build
builddir /var/lib/buildbot/slaves/slave/Linux64_-_Nginx__Mainline_/build SetPropertyFromCommand Step
buildername Linux64 - Nginx (Mainline) Builder
buildnumber 15 Build
codebase Build
github_repo_name ModSecurity Builder
github_repo_owner SpiderLabs Builder
got_revision b058a9f8ba90849262302a9e987d021bad02de84 Git
project Build
repository https://github.com/SpiderLabs/ModSecurity Build
revision b058a9f8ba90849262302a9e987d021bad02de84 Build
scheduler all-any Scheduler
slavename Linux64 BuildSlave
warnings-count 3977 WarningCountingShellCommand
workdir /var/lib/buildbot/slaves/slave/Linux64_-_Nginx__Mainline_ slave (deprecated)

Forced Build Properties:

NameLabelValue

Responsible Users:

  1. Andrei Belov
  2. Felipe Zimmerle
  3. paulyang

Timing:

StartTue Jul 29 21:17:32 2014
EndWed Jul 30 00:39:11 2014
Elapsed3 hrs, 21 mins, 38 secs

All Changes:

:

  1. Change #13

    Category None
    Changed by Felipe Zimmerle <fcostaohnoyoudont@trustwave.com>
    Changed at Tue 29 Jul 2014 19:11:52
    Repository https://github.com/SpiderLabs/ModSecurity
    Branch nginx_refactoring
    Revision af65e5209c8914616ff3dcd5ccb80f37a9f94829

    Comments

    nginx refactoring
    
    Refactoring on the nginx module, including:
     - Better handling larger posts;
     - Now using nginx echo module during the regression tests.
     - Better interacting with neginx chain rules
     - Separation of the request handling and content filters.
     - Better handling nginx sessions and resource counts to allow a
       more efficient garbage collector.
     - Handling both http/1.0 and 1.1, including keep-alive.
     - Tests are now capable to test nginx as a proxy or end-server.
     - Tested agains nginx 1.6 and 1.7.

    Changed files

    • nginx/modsecurity/apr_bucket_nginx.c
    • nginx/modsecurity/ngx_http_modsecurity.c
    • tests/regression/misc/00-phases.t
    • tests/regression/misc/25-libinjection.t
    • tests/regression/nginx/conf/nginx.conf.template
  2. Change #14

    Category None
    Changed by Felipe Zimmerle <fcostaohnoyoudont@trustwave.com>
    Changed at Tue 29 Jul 2014 19:11:52
    Repository https://github.com/SpiderLabs/ModSecurity
    Branch nginx_refactoring
    Revision 67c3b61a5470984f6881af9d4931412d8ab6956c

    Comments

    nginx: looking for segfaults on the regression test.
    
    If nginx segfaults it will return, warning that the test failed.

    Changed files

    • tests/run-regression-tests-nginx.pl
  3. Change #15

    Category None
    Changed by Felipe Zimmerle <fcostaohnoyoudont@trustwave.com>
    Changed at Tue 29 Jul 2014 19:11:52
    Repository https://github.com/SpiderLabs/ModSecurity
    Branch nginx_refactoring
    Revision bb3f9d1a40d572ca5c523157b32e4e5516eb349b

    Comments

    nginx: better dealing with chunked request body

    Changed files

    • nginx/modsecurity/ngx_http_modsecurity.c
    • tests/regression/nginx/conf/nginx.conf.template
  4. Change #16

    Category None
    Changed by Felipe Zimmerle <fcostaohnoyoudont@trustwave.com>
    Changed at Tue 29 Jul 2014 19:11:52
    Repository https://github.com/SpiderLabs/ModSecurity
    Branch nginx_refactoring
    Revision 55fa1bcd985e93864998783e4e4b0baa62fe7ca7

    Comments

    nginx: copies the req body chain to be processed instead of move
    
    Add a check for the definition MOVE_REQUEST_CHAIN_TO_MODSEC, whenever it is
    set the chain will be moved into the brigade. If it was not set the chain
    will be only copied. Moving was causing segfaults on the following
    regression tests:
    
     #15 - SecRequestBodyInMemoryLimit
     #16 - SecRequestBodyInMemoryLimit (greater)
     #19 - SecRequestBodyLimitAction ProcessPartial (multipart/greater - chunked)
     (from: regression/config/10-request-directives.t)

    Changed files

    • nginx/modsecurity/apr_bucket_nginx.c
    • nginx/modsecurity/apr_bucket_nginx.h
    • nginx/modsecurity/ngx_http_modsecurity.c
  5. Change #17

    Category None
    Changed by Felipe Zimmerle <fcostaohnoyoudont@trustwave.com>
    Changed at Tue 29 Jul 2014 19:11:52
    Repository https://github.com/SpiderLabs/ModSecurity
    Branch nginx_refactoring
    Revision 6029d1b2b8f0429b0beba298c7eab04ce7c03af4

    Comments

    Regression: Accept different ports on FULL_REQUEST unit test.
    
    FULL_REQUEST unit test was expecting only for the default regression test
    suite port. Now it is expecting for [0-9]+.

    Changed files

    • tests/regression/target/00-targets.t
  6. Change #18

    Category None
    Changed by Felipe Zimmerle <fcostaohnoyoudont@trustwave.com>
    Changed at Tue 29 Jul 2014 19:11:52
    Repository https://github.com/SpiderLabs/ModSecurity
    Branch nginx_refactoring
    Revision 953b3f5b8913a3a259395383e8c350f3ac3e65dd

    Comments

    nginx: cosmetics: Splits lines longer than 80 characters

    Changed files

    • nginx/modsecurity/apr_bucket_nginx.c
    • nginx/modsecurity/apr_bucket_nginx.h
    • nginx/modsecurity/ngx_http_modsecurity.c
    • nginx/modsecurity/ngx_pool_context.c
    • nginx/modsecurity/ngx_pool_context.h
  7. Change #19

    Category None
    Changed by Felipe Zimmerle <fcostaohnoyoudont@trustwave.com>
    Changed at Tue 29 Jul 2014 19:11:53
    Repository https://github.com/SpiderLabs/ModSecurity
    Branch nginx_refactoring
    Revision a0cd48e49632d5db01f536a5179640458cdcb105

    Comments

    nginx: cosmetics: Removes trailing whitespace

    Changed files

    • nginx/modsecurity/ngx_http_modsecurity.c
    • nginx/modsecurity/ngx_pool_context.c
  8. Change #20

    Category None
    Changed by Felipe Zimmerle <fcostaohnoyoudont@trustwave.com>
    Changed at Tue 29 Jul 2014 19:11:53
    Repository https://github.com/SpiderLabs/ModSecurity
    Branch nginx_refactoring
    Revision 462440c577e4c8e0c93f28040decb0c185c66ba8

    Comments

    niginx: cosmetics: Changes CRLF to LF

    Changed files

    • nginx/modsecurity/apr_bucket_nginx.c
    • nginx/modsecurity/apr_bucket_nginx.h
  9. Change #21

    Category None
    Changed by paulyang <paulyang.infohnoyoudont@gmail.com>
    Changed at Tue 29 Jul 2014 19:11:53
    Repository https://github.com/SpiderLabs/ModSecurity
    Branch nginx_refactoring
    Revision 7af608fd34343b5a2fa640478f0d7e2cff62c817

    Comments

    Bugfix: add -P option in test script
    
    Otherwise nginx's installation directory could not be specified.
    
    Signed-off-by: paulyang <paulyang.inf@gmail.com>

    Changed files

    • tests/run-regression-tests-nginx.pl
  10. Change #22

    Category None
    Changed by Andrei Belov <defanatorohnoyoudont@gmail.com>
    Changed at Tue 29 Jul 2014 19:11:53
    Repository https://github.com/SpiderLabs/ModSecurity
    Branch nginx_refactoring
    Revision db20746d22abdbd4fc9eeea30f51cf01dbffd961

    Comments

    Removed unneeded and invalid initialization.

    Changed files

    • nginx/modsecurity/ngx_http_modsecurity.c
  11. Change #23

    Category None
    Changed by Andrei Belov <defanatorohnoyoudont@gmail.com>
    Changed at Tue 29 Jul 2014 19:11:53
    Repository https://github.com/SpiderLabs/ModSecurity
    Branch nginx_refactoring
    Revision b058a9f8ba90849262302a9e987d021bad02de84

    Comments

    Obtain port from r->connection->local_sockaddr.
    
    This eliminates segfaults caused by unset (NULL) r->port_start
    and non-NULL r->port_end. In fact, r->port_start is always NULL,
    so it is useless to rely on this pointer.

    Changed files

    • nginx/modsecurity/ngx_http_modsecurity.c